Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated bridge types #595

Merged
merged 2 commits into from
May 3, 2021
Merged

Remove deprecated bridge types #595

merged 2 commits into from
May 3, 2021

Conversation

k1rill-fedoseev
Copy link
Member

Only three bridge types are currently maintained and actively used:

  • ARBITRARY_MESSAGE
  • ERC_TO_NATIVE
  • AMB_ERC_TO_ERC

All other bridge types (NATIVE_TO_ERC, ERC_TO_ERC, AMB_ERC_TO_NATIVE, AMB_NATIVE_TO_ERC, STAKE_AMB_ERC_TO_ERC, MULTI_AMB_ERC_TO_ERC) can be safely removed from the head of the repo.

Closes #591

@k1rill-fedoseev k1rill-fedoseev requested a review from akolotov May 2, 2021 16:53
@k1rill-fedoseev k1rill-fedoseev self-assigned this May 2, 2021
@akolotov akolotov merged commit aa771ec into develop May 3, 2021
@akolotov akolotov deleted the remove/prune-legacy-bridge-types branch May 3, 2021 13:59
@akolotov akolotov mentioned this pull request May 4, 2021
Merged
akolotov added a commit that referenced this pull request May 4, 2021
@akolotov
Merge the develop branch to the master branch, preparation to v5.7.0-rc1
7edfe77 
This set of changes includes the following improvements and few fixes:
  * [Improvement] Earn interest on locked tokens using Compound Protocol (#590)
  * [Other] Remove deprecated bridge types (#595)
  * [Other] Bump contracts and package version before 5.7.0-rc1 (#597)
uheqiang pushed a commit to uheqiang/tokenbridge-contracts that referenced this pull request May 10, 2021
Revert "Remove deprecated bridge types (omni#595)"
a73a524 
This reverts commit aa771ec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akolotov akolotov akolotov approved these changes

Assignees

@k1rill-fedoseev k1rill-fedoseev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@k1rill-fedoseev @akolotov