feat: Add send_state parameter to disable sending of state
#182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 8d1f8ed.
stanhu
force-pushed
the
sh-introduce-send-state-option
branch
from
8219089 to
a090124
Compare
This reverts #181 and adds a `send_state` parameter instead to address #174. According to https://openid.net/specs/openid-connect-core-1_0.html#rfc.section.3.1.2.1, `state` is recommended but not required: ``` state RECOMMENDED. Opaque value used to maintain state between the request and the callback. Typically, Cross-Site Request Forgery (CSRF, XSRF) mitigation is done by cryptographically binding the value of this parameter with a browser cookie. ``` In #181 we attempted to make `require_state` skip the `state` verification if it were `true`, but this was reverted for two reasons: 1. If identity providers make direct requests to the callback phase with a valid token, no `state` is passed in the request. If `require_state` were `true`, this change fails the request and breaks existing flows. 2. If `state` isn't sent in the first place, it should not be verified. `send_state` will now disable the sending of a `state` in the authorize phase.
stanhu
force-pushed
the
sh-introduce-send-state-option
branch
from
a090124 to
1e70c98
Compare
bufferoverflow
approved these changes
Jul 3, 2024
syakovyn
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts #181 and adds a
send_stateparameter instead to address #174.According to https://openid.net/specs/openid-connect-core-1_0.html#rfc.section.3.1.2.1,
stateis recommended but not required:In #181 we attempted to make
require_stateskip thestateverification if it weretrue, but this was reverted for two reasons:If identity providers make direct requests to the callback phase with a valid token, no
stateis passed in the request. Ifrequire_stateweretrue, this change fails the request and breaks existing flows.If
stateisn't sent in the first place, it should not be verified.send_statewill now disable the sending of astatein the authorize phase.