You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
How were the CRC failures manifesting for you? Or did you just pick this fix up from upstream zlib?
We have not hit any CRC failures yet but there seems to be software in the wild triggering it. madler/zlib#613 (comment)
I ask because we have an OS-8369 branch in illumos-extra with a bring-in of 1.2.12 and our first test Triton Compute Nodes would not come up (failing in system/zones). I may, time permitting, build OS-8369 with this patch added and see what happens. (illumos-extra and zlib don't play nicely together, and I may fix illumos-extra if I can to play more nicely with the very odd, unusual, and not-very-nice zlib ./configure.)
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.