Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecation of OmegaConf.get_resolver() #608

Closed
odelalleau opened this issue Mar 16, 2021 · 0 comments · Fixed by #609
Closed

Deprecation of OmegaConf.get_resolver() #608

odelalleau opened this issue Mar 16, 2021 · 0 comments · Fixed by #609
Assignees
@odelalleau
Milestone
OmegaConf 2.1

Comments

@odelalleau
Copy link
Collaborator

PROBLEM

OmegaConf.get_resolver() is exposing OmegaConf internals that are not meant to be public-facing (they may change arbitrarily).

DEPRECATION PLAN

  • OmegaConf.get_resolver() is being deprecated in OmegaConf 2.1 and will be removed in OmegaConf 2.2.
  • A new function OmegaConf.has_resolver(name: str) -> bool is being added in OmegaConf 2.1 to make it possible to check for the existence of a resolver. If this new function is not enough for your use case, please open an issue explaining why.

Additional context
See discussion in #599 (comment)
@odelalleau odelalleau self-assigned this Mar 16, 2021
@odelalleau odelalleau added this to the OmegaConf 2.1 milestone Mar 16, 2021
@odelalleau odelalleau mentioned this issue Mar 16, 2021
Closed
22 tasks
odelalleau added a commit to odelalleau/omegaconf that referenced this issue Mar 16, 2021
@odelalleau
Deprecate get_resolver() and add new has_resolver()
71a3648 
Fixes omry#608
@odelalleau odelalleau mentioned this issue Mar 16, 2021
Merged
odelalleau added a commit that referenced this issue Mar 16, 2021
@odelalleau
Deprecate get_resolver() and add new has_resolver() (#609)
4968d70 
* Deprecate `get_resolver()` and add new `has_resolver()`

Fixes #608

* Refactor: move private functions at bottom of class

* Add test for coverage of deprecation warning
pixelb added a commit to pixelb/omegaconf that referenced this issue May 12, 2022
@pixelb
remove support for OmegaConf.get_resolver()
ee3016a 
Users should use OmegaConf.has_resolver() instead.

Was slated for removal in 2.2

The deprecation was handled in issue omry#608
This addresses issue omry#821
@pixelb pixelb mentioned this issue May 12, 2022
Merged
pixelb added a commit that referenced this issue May 12, 2022
@pixelb
remove support for OmegaConf.get_resolver()
5c1fe43 
Users should use OmegaConf.has_resolver() instead.

Was slated for removal in 2.2

The deprecation was handled in issue #608
This addresses issue #821
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@odelalleau odelalleau

Labels
None yet
Projects
None yet
Milestone
OmegaConf 2.1
Development

Successfully merging a pull request may close this issue.

Deprecate get_resolver() and add new has_resolver() odelalleau/omegaconf
2 participants
@odelalleau @Jasha10