Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate public OmegaConf.is_optional() API #698

Closed
Jasha10 opened this issue Apr 28, 2021 · 0 comments · Fixed by #700
Closed

Deprecate public OmegaConf.is_optional() API #698

Jasha10 opened this issue Apr 28, 2021 · 0 comments · Fixed by #700
Labels
In progress
Milestone
OmegaConf 2.1

Comments

@Jasha10
Copy link
Collaborator

Jasha10 commented Apr 28, 2021 •
edited by omry
Loading

For deprecation of the public OmegaConf.is_optional() method in favor of a private (internal) method.

Based on comment posted by @omry in #696 (comment)

If you have a use case for OmegaConf.is_optional() please let us know what it is.
@Jasha10 Jasha10 mentioned this issue Apr 28, 2021
Merged
@Jasha10 Jasha10 added this to the OmegaConf 2.1 milestone Apr 28, 2021
@Jasha10 Jasha10 mentioned this issue Apr 28, 2021
Merged
pixelb added a commit to pixelb/omegaconf that referenced this issue May 12, 2022
@pixelb
remove support for OmegaConf.is_optional()
81d288e 
Was slated for removal in 2.2

The deprecation was handled in issue omry#698
This addresses issue omry#821
@pixelb pixelb mentioned this issue May 12, 2022
Merged
pixelb added a commit to pixelb/omegaconf that referenced this issue May 12, 2022
@pixelb
remove support for OmegaConf.is_optional()
70f5d29 
Was slated for removal in 2.2

The deprecation was handled in issue omry#698
This addresses issue omry#821
pixelb added a commit to pixelb/omegaconf that referenced this issue May 13, 2022
@pixelb
remove support for OmegaConf.is_optional()
6097e85 
Was slated for removal in 2.2

The deprecation was handled in issue omry#698
This addresses issue omry#821
pixelb added a commit that referenced this issue May 13, 2022
@pixelb
remove support for OmegaConf.is_optional()
b836ba5 
Was slated for removal in 2.2

The deprecation was handled in issue #698
This addresses issue #821
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
In progress
Projects
None yet
Milestone
OmegaConf 2.1
Development

Successfully merging a pull request may close this issue.

Deprecate OmegaConf.is_optional Jasha10/omegaconf
1 participant
@Jasha10