Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

readthedocs: install java via post_system_dependencies hook #1143

Merged

Conversation

Jasha10
Copy link
Collaborator

@Jasha10 Jasha10 commented Nov 15, 2023

This is a follow-up to PR #1142 that changes the .readthedocs config file.
Rather than using the build.commands key to install java, we use build.jobs.post_system_dependencies.
The problem with the previous approach is that build.command overrides all other build steps performed by readthedocs, which we do not want.

image

@Jasha10 Jasha10 merged commit 0a0a6c6 into omry:master Nov 15, 2023
1 of 5 checks passed
@Jasha10 Jasha10 deleted the jasha-fix-redthedocs-extend-build-process branch November 18, 2023 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant