Use CSafeLoader when possible #1150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odelalleau
requested changes
Jan 16, 2024
Done, let me know if that looks good to you! By the way, it might be worth adding something about news fragments in |
odelalleau
requested changes
Jan 16, 2024
Good point, see #1151 (unfortunately I can't add you as reviewer) |
Co-authored-by: Olivier Delalleau <507137+odelalleau@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
yaml.CSafeLoaderis significantly faster. However, it is not always available. The proposed change is to use it whenever it is available with a fall back toyaml.SafeLoader(current loader).Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
No additional tests required, current tests should cover yaml being parsed correctly.
Fixes
What issue does this PR fix? Use https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue to link this PR to a corresponding issue.
Fixes #1149
Related PRs