678 select

[omry]

Followup to discussion 678. easier to review individual commits.

1. eliminating redundant tests.
2. Change exception raised when trying to drill into a non-container with select from ConfigKeyError to ConfigTypeError.
3. Change OmegaConf.select to return None if user attempts to drill into a non existing node (into a ValueNode or into None).

Closes #678

[odelalleau]

Besides the comment below:

• News item?
• Maybe also consider fixing the case with a None container in this PR: {"x": "${y.z}", "y": DictConfig(None)} (ok too to leave it for another PR if you prefer)

[omry]

Besides the comment below:

• News item?
• Maybe also consider fixing the case with a None container in this PR: {"x": "${y.z}", "y": DictConfig(None)} (ok too to leave it for another PR if you prefer)

1. Added news item.
2. Do you mean:

OmegaConf.create({"x": "${y.z}", "y": DictConfig(None)}).x

Raising the wrong exception?
this seems to be an existing (low priority) bug that is not related to this one.

File a separate issue?

[odelalleau]

File a separate issue?

New issue: #685

[odelalleau]

Good to merge after fixing this small typo!

[omry]

File a separate issue?

New issue: #685

Actually not the same issue I was thinking about.
Run this:

OmegaConf.create({"x": "${y.z}", "y": DictConfig(None)}).x

no OmegaConf.select involved.

[odelalleau]

File a separate issue?

New issue: #685

Actually not the same issue I was thinking about.
Run this:

OmegaConf.create({"x": "${y.z}", "y": DictConfig(None)}).x

no OmegaConf.select involved.

Hopefully both can be fixed at the same time :)

[omry]

Looks like the fix accidentally fixed the other bug:

OmegaConf.create({"x": "${y.z}", "y": DictConfig(None)}).x
...
InterpolationKeyError: Interpolation key 'y.z' not found
    full_key: x
    object_type=dict

[odelalleau]

Looks like the fix accidentally fixed the other bug:

Nice -- that's what I was hoping for since both were raising the same exception.