-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added clear_resolver method to OmegaConf #770
Merged
Jasha10
merged 21 commits into
omry:master
from
sugatoray:feature/769_clear_single_resolver
Aug 5, 2021
Merged
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
7ea9ae3
added clear_resolver method to OmegaConf
sugatoray 46c1021
added tests and simplified some code
sugatoray 9ed558d
Added test scenario for Error
sugatoray 9812ce9
updated OmegaConf.clear_resolver method
sugatoray 77fca7c
Updated test_omegaconf.py::test_clear_resolver
sugatoray ce7a05c
updated test_omegaconf.py::test_clear_resolver
sugatoray f62b567
Updated logic for OmegaConf.clear_resolver
sugatoray 64ca79d
Added section for clearing resolver(s) in docs
sugatoray 76179cd
updated docs examples for clearing resolver(s)
sugatoray 5ec405a
Merge branch 'omry:master' into feature/769_clear_single_resolver
sugatoray 5074cf4
cleaning up inside OmegaConf.clear_resolver
sugatoray cc974b6
cleaned up comments from test_omegaconf.py::test_clear_resolver
sugatoray 324d0e1
made changes to test_omegaconf.py::test_clear_resolver
sugatoray 8da4cbc
Update docs/source/custom_resolvers.rst
sugatoray 2cb44f8
updated docs for OmegaConf.clear_resolvers
sugatoray 350011b
changes to tests and docs
sugatoray 8e51670
Update docs/source/custom_resolvers.rst
sugatoray 1b687a4
Update docs/source/custom_resolvers.rst
sugatoray 8d6c609
Update omegaconf/omegaconf.py
sugatoray 1d209ca
Update docs/source/custom_resolvers.rst
sugatoray a42bc44
Update omegaconf/omegaconf.py
sugatoray File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The contract of this function is very simple, I am not convinced that it needs an example at all.
I vote to remove the example.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Granted it's down right simple 😉 . But, I believe, examples are kind of a major useful feature of the documentation of this library. So, I thought if it is made clear through an example, it will be helpful. I wanted to show that custom resolvers are removed, while default ones are not, when
clear_resolvers()
is used.However, if you insist on it's (the example: starting from line-412) removal, that's okay as well. 😄