Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unpin mypy #863

Merged
merged 4 commits into from
Feb 17, 2022
Merged

Unpin mypy #863

merged 4 commits into from
Feb 17, 2022

Conversation

Jasha10
Copy link
Collaborator

@Jasha10 Jasha10 commented Feb 17, 2022

To conform with the MutableMapping API, The DictConfig.items method now returns an object of type ItemsView, and DictConfig.keys will now always return a KeysView.

pixelb
pixelb approved these changes Feb 17, 2022
View reviewed changes
Copy link
Collaborator

@pixelb pixelb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right we're returning a mutable view.
But doing that on a (list) copy, so there should not be any significant compat issues here I think.

thanks

@Jasha10 Jasha10 merged commit fd06224 into omry:master Feb 17, 2022
@Jasha10 Jasha10 deleted the unpin_mypy branch February 17, 2022 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pixelb pixelb pixelb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jasha10 @pixelb