Zaporizhzhia name update #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://en.wikipedia.org/wiki/Zaporizhzhia City in Ukraine, I saw you did changes for Kyiv, here is the same situation.
|
Hi @Ilyahas, thanks for the update. |
|
Just found: "Odessa" has to be "Odesa" https://en.wikipedia.org/wiki/Odesa https://github.com/omsrivastava/timezones-list/blob/master/src/timezones.json#L1601 |
|
@omsrivastava can you update version and let's merge it :) |
BohdanK-W32
approved these changes
Apr 24, 2023
raphaelpinel
approved these changes
Jun 15, 2023
raphaelpinel
approved these changes
Jun 15, 2023
VitaliiLazebnyi
approved these changes
Jul 27, 2023
There was a problem hiding this comment.
The PR still needs updating of versions just like it was done here: https://github.com/omsrivastava/timezones-list/pull/10/files
And it belive it's about time to merge it.
omsrivastava
approved these changes
Jan 13, 2024
|
These changes doesn't match with moment.js timezone list and breaks our integration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://en.wikipedia.org/wiki/Zaporizhzhia
City in Ukraine. I saw you did changes for Kyiv, here is the same situation.