Update page header name and create new rich page header #1393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciremusyoka
force-pushed
the
reusable-page-headers-1388
branch
from
99a34bd to
002f861
Compare
peterMuriuki
reviewed
May 2, 2024
packages/fhir-care-team/src/components/CreateEditCareTeam/Form.tsx
Outdated
Show resolved
Hide resolved
peterMuriuki
requested changes
May 8, 2024
| @@ -1,13 +1,13 @@ | |||
| import React from 'react'; | |||
There was a problem hiding this comment.
Should we remove this now?
Comment on lines
+149
to
+154
| const headerProps = { | ||
| pageHeaderProps: { | ||
| title: pageTitle, | ||
| onBack: undefined, | ||
| }, | ||
| }; |
There was a problem hiding this comment.
This is missing the navigation breadcrumb
There was a problem hiding this comment.
Currently have not added breadcrumb to all the pages as per the designs on this PR. I only added to the pages the breadcrumbs already existed.
Created an issue here to match all headers with the designs here.
peterMuriuki
previously approved these changes
May 8, 2024
ciremusyoka
force-pushed
the
reusable-page-headers-1388
branch
from
64d3e02 to
6de1086
Compare
peterMuriuki
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #1388
Changes included with this PR
Checklist