Fix duplicate location inventory when adding an inventory #1400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciremusyoka
approved these changes
May 13, 2024
sharon2719
pushed a commit
that referenced
this pull request
May 20, 2024
* Check locationInventory list before creating new one * Show all inventory even if they share duplicate products * Fix how the global inventory list resource is updated * Cleanup dockstring * Update tests * Add a todo * Update snapshot test
peterMuriuki
added a commit
that referenced
this pull request
Jun 6, 2024
* Add patient list view * Add patient list view * Update PatientlistView * Remove unused folder * Fix details * Fix duplicate location inventory when adding an inventory (#1400) * Check locationInventory list before creating new one * Show all inventory even if they share duplicate products * Fix how the global inventory list resource is updated * Cleanup dockstring * Update tests * Add a todo * Update snapshot test * Remove unchanged files * Resolve changes * Fix lint issues * Finalize changes to lisyview * Adjust view according to designs * fix lint * Update index.tsx * Rename files * Final lint fix * Fix build issue * Update the designs and test * Update tests (#1427) * Update and fix failing tests * Fix Linting error * Update packages/fhir-client/src/components/PatientDetailsOverview/index.tsx Updte PatientDetailsOverview Co-authored-by: Peter Muriuki <pmuriuki98@gmail.com> * Update packages/react-utils/src/components/KeyValuePairs/index.tsx Co-authored-by: Peter Muriuki <pmuriuki98@gmail.com> --------- Co-authored-by: Peter Muriuki <pmuriuki98@gmail.com> Co-authored-by: Eric Musyoka <wambua.eric01@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
**closes #1384 **
updated the post inventory util function to only create a new location inventory list resource when editing an existing inventory, not to do so when adding a new inventory to a location that has previous assignments .
Update inventory view details section to see all inventories attached to a location even if sharing products
Checklist