Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update express version in DockerFilie #1464

Merged
merged 4 commits into from
Aug 30, 2024
Merged

Update express version in DockerFilie #1464

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c8f0e33
Update express version in DockerFilie
peterMuriuki Aug 30, 2024
85137a3
Update base image for buliding express server
peterMuriuki Aug 30, 2024
dd70fb4
Enable corepack in node js images
peterMuriuki Aug 30, 2024
34b977a
Merge branch 'main' into update-docker-express
peterMuriuki Aug 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
FROM alpine/git AS sources

# TODO - update the tag here
RUN git clone --branch=v2.1.1-rc1 https://github.com/onaio/express-server.git /usr/src/express-server
RUN git clone --branch=v2.1.1-rc3 https://github.com/onaio/express-server.git /usr/src/express-server

FROM node:16.18-alpine as build

Expand All @@ -23,7 +23,9 @@ USER node
RUN yarn lerna run build


FROM node:16.18-alpine as nodejsbuild
FROM node:20-alpine as nodejsbuild

RUN corepack enable

COPY --from=sources /usr/src/express-server /usr/src/express-server

Expand All @@ -37,6 +39,8 @@ RUN rm -rf ./node_modules/typescript

FROM nikolaik/python-nodejs:python3.12-nodejs22-alpine as final

RUN corepack enable

# Use tini for NodeJS application https://github.com/nodejs/docker-node/blob/master/docs/BestPractices.md#handling-kernel-signals
RUN apk add --no-cache tini curl libmagic

Expand Down
Loading