Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Giz user extra fields #1469

Merged
merged 16 commits into from
Sep 13, 2024
Merged

Giz user extra fields #1469

merged 16 commits into from
Sep 13, 2024

Conversation

kahummer
Copy link
Collaborator

closes #1467

Changes included with this PR

  • Add extra fields(national id and phone number) on user form
  • Pushes fields values to practitioner resource

Checklist

  • tests are included and passing
  • documentation is changed or added
  • Internationalization:
    • Ensure all strings are internationalized.
  • Role-Based Access:
    • Verify that all user actions have appropriate role-based access permissions set.

@kahummer kahummer self-assigned this Sep 10, 2024
@kahummer kahummer added the WIP Work In Progress label Sep 10, 2024
Comment on lines 111 to 112
[t('National ID')]: attributes?.nationalId,
[t('Phone Number')]: attributes?.phoneNumber,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: could we re-use the same spread pattern for optional computed properties like shown below:
...(nationalId ? { nationalId: [nationalId] } : {}),

peterMuriuki
peterMuriuki previously approved these changes Sep 13, 2024
@kahummer kahummer merged commit 43675f3 into main Sep 13, 2024
0 of 2 checks passed
@kahummer kahummer deleted the giz-user-extra-fields branch September 13, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WIP Work In Progress
Projects
None yet
2 participants