Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support reference genome #102

Merged
merged 1 commit into from
Oct 13, 2020
Merged

Support reference genome #102

merged 1 commit into from
Oct 13, 2020

Conversation

zhx828
Copy link
Member

@zhx828 zhx828 commented Oct 9, 2020

This fixes #68

@zhx828 zhx828 added the feature Feature tag for release label Oct 9, 2020
@zhx828 zhx828 requested review from jjgao and Leowisd October 9, 2020 19:42
jjgao
jjgao reviewed Oct 13, 2020
View reviewed changes
Copy link
Member

@jjgao jjgao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Maybe we also want to have a grch38-based maf for testing?

@zhx828
Copy link
Member Author

zhx828 commented Oct 13, 2020

Looks good. Maybe we also want to have a grch38-based maf for testing?

That's a good idea. I will add.

Support reference genome
8d70c4d 
Add GRCh38 example maf file

Update README.md
@zhx828 zhx828 merged commit 75571ce into oncokb:master Oct 13, 2020
@zhx828 zhx828 deleted the support-rg branch November 7, 2020 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjgao jjgao jjgao left review comments

@Leowisd Leowisd Awaiting requested review from Leowisd

Assignees
No one assigned
Labels
feature Feature tag for release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add option to change reference genome in annotators
2 participants
@zhx828 @jjgao