Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add flake8 github action and fix all flake8 errors #179

Merged
merged 2 commits into from
Jun 15, 2022
Merged

Add flake8 github action and fix all flake8 errors #179

merged 2 commits into from
Jun 15, 2022

Conversation

zhx828
Copy link
Member

@zhx828 zhx828 commented Jun 13, 2022

This fixes #178

@zhx828
Flake 8 updates
f4a69fc 
- Fix all format issues based on flake8
- Add flake8 github action to test all python files
@zhx828 zhx828 added the chore Maintenance tag for release label Jun 14, 2022
@zhx828 zhx828 requested a review from calvinlu3 June 14, 2022 20:39
@calvinlu3
Copy link

There's an issue with one of the tests.

@zhx828 zhx828 merged commit 8ddbb88 into master Jun 15, 2022
@zhx828
Copy link
Member Author

zhx828 commented Jun 15, 2022

There's an issue with one of the tests.

It's ok. It's been flaky.

@zhx828 zhx828 deleted the add-flake8 branch June 15, 2022 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calvinlu3 calvinlu3 calvinlu3 approved these changes

Assignees
No one assigned
Labels
chore Maintenance tag for release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Flake8 warnings
2 participants
@zhx828 @calvinlu3