Support python 3.11 #190
Merged
Support python 3.11 #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhx828
changed the title
zhx828
force-pushed
the
skip-token-validation
branch
from
c0241bc
to
15b835c
Compare
zhx828
force-pushed
the
skip-token-validation
branch
from
15b835c
to
aedcf34
Compare
The yaml considers 3.10 as number and will convert it to 3.1
Few rationals behind removing matplotlib from dependency - we want to support the latest python version as soon as possible, but matplotlib usually has delay of being compatible - OncoKBPlots is not actively used internally, therefore we have no checks on whether it's working - OncoKBPlots actually produces low quality images which team does not like - we are not going to remove OncoKBPlots.py from the repo but just remove the matplotlib dependency. Anyone wants to use it can still install matplotlib at their well
zhx828
changed the title
The mode 'U' is no longer has any effect in python 3 and 3.11 completely removed the option.
zhx828
force-pushed
the
skip-token-validation
branch
from
849447d
to
ddcbf9b
Compare
calvinlu3
approved these changes
Jan 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #188