Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SYCLomatic] Adding test for permutation iterator with device_pointer source #614

Open
wants to merge 2 commits into
base: SYCLomatic
Choose a base branch
from
Open

[SYCLomatic] Adding test for permutation iterator with device_pointer source #614

wants to merge 2 commits into from

Conversation

danhoeflinger
Copy link
Contributor

Adding test for using permutation iterator with a device_pointer as source.

Used for checking proper support for USM_NONE case and USM cases.

@danhoeflinger danhoeflinger requested a review from a team as a code owner January 24, 2024 22:01
@danhoeflinger danhoeflinger force-pushed the dev/dhoeflin/permutation_device_ptr_Test branch from 5f4139f to 6917f77 Compare March 28, 2024 20:45
tomflinda
tomflinda requested changes Apr 18, 2024
View reviewed changes
Copy link
Contributor

@tomflinda tomflinda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls rebase to your PR to latest code repo and trigger CI test again.

@danhoeflinger danhoeflinger force-pushed the dev/dhoeflin/permutation_device_ptr_Test branch from 6917f77 to 3dee6cd Compare April 18, 2024 01:46
@danhoeflinger
Copy link
Contributor Author

Pls rebase to your PR to latest code repo and trigger CI test again.

@tomflinda Its been rebased and passed all testing.

@danhoeflinger danhoeflinger force-pushed the dev/dhoeflin/permutation_device_ptr_Test branch from 3dee6cd to 5d0df62 Compare July 8, 2024 18:08
@danhoeflinger
Copy link
Contributor Author

Rebased again. CI running

@danhoeflinger
Copy link
Contributor Author

I believe the CI errors are unrelated to this PR.

@danhoeflinger danhoeflinger force-pushed the dev/dhoeflin/permutation_device_ptr_Test branch from 5d0df62 to eb409dc Compare July 22, 2024 17:10
@danhoeflinger
Adding tests for device_pointer inside a permutation_iterator
c23d65e 
Signed-off-by: Dan Hoeflinger <dan.hoeflinger@intel.com>
@danhoeflinger
formatting
c9bdf42 
Signed-off-by: Dan Hoeflinger <dan.hoeflinger@intel.com>
@danhoeflinger danhoeflinger force-pushed the dev/dhoeflin/permutation_device_ptr_Test branch from eb409dc to c9bdf42 Compare August 19, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShengchenJ ShengchenJ Awaiting requested review from ShengchenJ ShengchenJ is a code owner automatically assigned from oneapi-src/syclomatic-reviewers

@AndyCHHuang AndyCHHuang Awaiting requested review from AndyCHHuang AndyCHHuang is a code owner automatically assigned from oneapi-src/syclomatic-reviewers

@tomflinda tomflinda Awaiting requested review from tomflinda

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danhoeflinger @tomflinda