Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Remove unneeded .def files #2974

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

david-cortes-intel
Copy link
Contributor

Description

This PR removes BLAS and LAPACK functions from the .def files that export them in oneDAL's .dlls for windows.

After the move to oneMKL, these shouldn't be necessary anymore.


PR should start as a draft, then move to ready for review state after CI is passed and all applicable checkboxes are closed.
This approach ensures that reviewers don't spend extra time asking for regular requirements.

You can remove a checkbox as not applicable only if it doesn't relate to this PR in any way.
For example, PR with docs update doesn't require checkboxes for performance while PR with any change in actual code should have checkboxes and justify how this code change is expected to affect performance (or justification should be self-evident).

Checklist to comply with before moving PR from draft:

PR completeness and readability

  • I have reviewed my changes thoroughly before submitting this pull request.
  • Git commit message contains an appropriate signed-off-by string (see CONTRIBUTING.md for details).
  • I have added a respective label(s) to PR if I have a permission for that.
  • I have resolved any merge conflicts that might occur with the base branch.

Testing

  • I have run it locally and tested the changes extensively.
  • All CI jobs are green or I have provided justification why they aren't.

Performance

Not applicable.

@david-cortes-intel david-cortes-intel added the dependencies Pull requests that update a dependency file label Nov 12, 2024
@david-cortes-intel david-cortes-intel marked this pull request as draft November 12, 2024 14:20
@david-cortes-intel
Copy link
Contributor Author

/intelci: run

@david-cortes-intel
Copy link
Contributor Author

/intelci: run

@david-cortes-intel david-cortes-intel changed the title MAINT: Remove blas and lapack functions from .def lists MAINT: Remove unneeded .def files Nov 15, 2024
@david-cortes-intel
Copy link
Contributor Author

Looks like empty .def files (with just "export") were indeed needed by some make scripts:

make: *** No rule to make target '__work/md/lnx32e/threading_dynamic/libonedal_thread_link.def', needed by '__work/md/lnx32e/daal/lib/libonedal_thread.so'.  Stop.

@Alexandr-Solovev Any idea of why that might be the case?

@Alexandr-Solovev
Copy link
Contributor

Looks like empty .def files (with just "export") were indeed needed by some make scripts:

make: *** No rule to make target '__work/md/lnx32e/threading_dynamic/libonedal_thread_link.def', needed by '__work/md/lnx32e/daal/lib/libonedal_thread.so'.  Stop.

@Alexandr-Solovev Any idea of why that might be the case?

Interesting, I will take a look

@Alexandr-Solovev
Copy link
Contributor

Alexandr-Solovev commented Nov 15, 2024

@david-cortes-intel
I locally fixed it, not sure that all tests are passed, but it builds successfully
Firstly I removed this:
https://github.com/oneapi-src/oneDAL/blob/main/makefile#L843
https://github.com/oneapi-src/oneDAL/blob/main/makefile#L844
And also removed $(THR.tmpdir_y)/$(thr_tbb_y:%.$y=%_link.def) from this line https://github.com/oneapi-src/oneDAL/blob/main/makefile#L848
Looks like it searches .def files for threading and returns error.
Can you apply this changes and check it?
upd: I also removed https://github.com/oneapi-src/oneDAL/blob/main/makefile#L492
and oneDAL/cpp/daal/src/algorithms/export_win32e.def but it probably affects windows, didnt test it

@david-cortes-intel
Copy link
Contributor Author

/intelci: run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants