-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAINT: Remove unneeded .def files #2974
base: main
Are you sure you want to change the base?
MAINT: Remove unneeded .def files #2974
Conversation
/intelci: run |
/intelci: run |
Looks like empty .def files (with just "export") were indeed needed by some make scripts:
@Alexandr-Solovev Any idea of why that might be the case? |
Interesting, I will take a look |
@david-cortes-intel |
/intelci: run |
Description
This PR removes BLAS and LAPACK functions from the
.def
files that export them in oneDAL's .dlls for windows.After the move to oneMKL, these shouldn't be necessary anymore.
PR should start as a draft, then move to ready for review state after CI is passed and all applicable checkboxes are closed.
This approach ensures that reviewers don't spend extra time asking for regular requirements.
You can remove a checkbox as not applicable only if it doesn't relate to this PR in any way.
For example, PR with docs update doesn't require checkboxes for performance while PR with any change in actual code should have checkboxes and justify how this code change is expected to affect performance (or justification should be self-evident).
Checklist to comply with before moving PR from draft:
PR completeness and readability
Testing
Performance
Not applicable.