-
Notifications
You must be signed in to change notification settings - Fork 988
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cpu: aarch64: fix jit_brgemm warnings #2118
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: yetao01 <ye.tao@arm.com>
Thanks for this, which compiler is that warning from? Does this mean we can turn on werror for one of the compilers now? |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Action is now on me to tighten Werror for ci.
If you are referring to out-of-bound access to |
@taoye9 can you please try @dzarukin's suggestion. If this works, please include it in this patch. If not, we can submit what we have, and take a look later. If the suggestion works, then if it is okay with other reviewers, please add an additional seperate commit to this PR to immediately enable Werror in our ci, and let's never worry about warnings again. |
Description
this change is to fix aarch64 compile warning so that we can enable Werror for aarch64 in the ci.
So far, we've fix t warnings inside oneDNN/src/cpu/aarch64/ folder.
Now only one warning remains, which info is as following.
The warning can be reproduced in ci [macOS (gcc-14, g++-14, Release, 0)]
Checklist
General
make test
andmake test_benchdnn_*
) pass locally for each commit?