Update matmul.md #2203
Open
Update matmul.md #2203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updated supported data types
github-actions
bot
added
the
documentation
|
Thanks for the PR. Could you please rename the commit message to adhere to the oneDNN coding guideline. |
|
@mgouicem message updated. thanks. |
shu1chen
reviewed
Nov 8, 2024
| @@ -188,6 +189,7 @@ memory buffer that shares its shape with the destination buffer). | |||
| * Runtime dimensions. | |||
| * Three and higher dimensional matrices. | |||
| - The layout of dropout mask has to be exactly the same as that of dst. | |||
| - f64 is only supported on Intel(R) Data Center GPU Max Series. | |||
There was a problem hiding this comment.
There might be other platforms supporting f64 in the future, it would be better not to mention this specific platform and align with the description in dev_guide_data_types.html:
f64 configurations are only supported on GPU engines with HW capability for double-precision floating-point.
ranukund
reviewed
Nov 8, 2024
| @@ -67,7 +67,7 @@ argument index as specified by the following table. | |||
| user must pass fully specified memory objects so that the primitive is able | |||
| to perform the computations. Note that the less information about shapes | |||
| or format is available at the creation stage, the less performant execution | |||
| will be. In particular, if the shape is not known at creation stage, one | |||
| will be. In particular, if the shape is not known at the creation stage, one | |||
There was a problem hiding this comment.
Suggested change
| will be. In particular, if the shape is not known at the creation stage, one | |
| will be. In particular, if the shape is not known at the creation stage, you |
| @@ -80,13 +80,13 @@ argument index as specified by the following table. | |||
| invalid. | |||
|
|
|||
| 3. The broadcasting shape consistency check is not done for the dimensions with | |||
| #DNNL_RUNTIME_DIM_VAL. It is user responsibility to make sure the dimensions | |||
| #DNNL_RUNTIME_DIM_VAL. It is the user's responsibility to make sure the dimensions | |||
There was a problem hiding this comment.
Suggested change
| #DNNL_RUNTIME_DIM_VAL. It is the user's responsibility to make sure the dimensions | |
| #DNNL_RUNTIME_DIM_VAL. Make sure the dimensions |
| for the tensors are valid. | ||
|
|
||
| 4. Multiple batch dimensions and broadcasting of batch dimensions of `src` and | ||
| `weights` are supported for both CPU and GPU engines. | ||
|
|
||
| Please check tutorials below to see #DNNL_RUNTIME_DIM_VAL support in use. | ||
| Please check the tutorials below to see #DNNL_RUNTIME_DIM_VAL support in use. |
There was a problem hiding this comment.
Suggested change
| Please check the tutorials below to see #DNNL_RUNTIME_DIM_VAL support in use. | |
| Check the tutorials below to see #DNNL_RUNTIME_DIM_VAL support in use. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc: matmul: updated supported data types