Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip Jit uni reorder if 4d matrix and zero point is defined #2205

Closed
wants to merge 1 commit into from

Conversation

Ryo-not-rio
Copy link
Contributor

Description

Jit:uni reorders for certain 4d matrices are returning incorrect results when the src zero point != 0. A guard has been added to skip jit uni reorders for any 4d matrices where src zero point != 0 so the simple:any implementation will be used. A new testcase has also been added to benchdnn.

Reproduction:

./tests/benchdnn/benchdnn --reorder  --sdt=u8 --ddt=f32 --stag=adbc --attr-zero-points=src:common:1 1x32x128x33

General

  • Do all unit and benchdnn tests (make test and make test_benchdnn_*) pass locally for each commit?
  • Have you formatted the code using clang-format?

Bug fixes

  • Have you included information on how to reproduce the issue (either in a github issue or in this PR)?
  • Have you added relevant regression tests?

Change-Id: I6b48ade2c84ab8c9e544e5540aab5410dbabb0bc
@Ryo-not-rio Ryo-not-rio requested review from a team as code owners November 7, 2024 13:40
@Ryo-not-rio Ryo-not-rio closed this Nov 7, 2024
@Ryo-not-rio Ryo-not-rio deleted the fix-reorder branch November 7, 2024 13:56
--attr-zero-points=src:common:-1
--stag=adbc
1x12x128x33

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe these test cases should already be covered in benchdnn/inputs/matmul/test_matmul_multidims.

I also think that adbc should be tested for more datatypes. Tagging @dzarukin on guidance here.

@github-actions github-actions bot added the platform:cpu-aarch64 Codeowner: @oneapi-src/onednn-cpu-aarch64 label Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform:cpu-aarch64 Codeowner: @oneapi-src/onednn-cpu-aarch64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants