cpu: aarch64: non-global stats mode for ACL lnorm #2209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
michalowski-arm
commented
Nov 8, 2024
•
michalowski-arm
commented
- Change acl_layer_normalization to support non-global stats only
- Remove mean and variance check for ACL lnorm from benchdnn
|
Could you please format the PR and the commit: |
|
We also need to remove skipped tests from GitHub actions from here: oneDNN/.github/automation/test_aarch64.sh Line 74 in 74e7e4d and in other places in this file. Then if the CI passes, we are good. |
michalowski-arm
force-pushed
the
acl-lnorm-fix
branch
from
7ab8e2b
to
31970a6
Compare
* Change acl_layer_normalization to support non-global stats only --
ACL does not support global stats
* Remove mean and variance check for ACL lnorm from benchdnn --
ACL does not support returning them
michalowski-arm
force-pushed
the
acl-lnorm-fix
branch
from
31970a6
to
018437f
Compare
theComputeKid
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.