Declare predefined dpcpp_default and dpcpp fpga policies as const
#1671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dpcpp_default as const Signed-off-by: Sergey Kopienko <sergey.kopienko@intel.com>
…dpcpp_fpga as const Signed-off-by: Sergey Kopienko <sergey.kopienko@intel.com>
SergeyKopienko
changed the title
dpcpp_default and dpcpp fpga policies as const
akukanov
reviewed
Jul 5, 2024
…cpp_fpga now declared as const Signed-off-by: Sergey Kopienko <sergey.kopienko@intel.com>
akukanov
reviewed
Jul 8, 2024
…t and dpcpp_fpga now declared as const" This reverts commit c1c778f.
|
We will need to update the docs if this change happens. I did a quick search and found that we cite device_policy in the following pages: Execution Policies, Macros, Pass Data to Algorithms. We cite fpga_policy in the following pages: Execution Policies and Macros. As long as I have guidance, I will update the docs as needed. |
…p_fpga_as_const Signed-off-by: Sergey Kopienko <sergey.kopienko@intel.com> # Conflicts: # include/oneapi/dpl/pstl/hetero/dpcpp/execution_sycl_defs.h
|
@dcbenito, @SergeyKopienko - I have added the documentation changes to the pull request, please take a look. |
dcbenito
previously approved these changes
Jul 31, 2024
| @@ -94,8 +94,8 @@ Macro Description | |||
| such as ``dpcpp_default`` and ``dpcpp_fpga``. When the macro is not defined (by default) | |||
| or evaluates to non-zero, predefined policies objects can be used. | |||
| When the macro is set to 0, predefined policies objects and make functions | |||
| without arguments, when ``make_device_policy()``, | |||
| ``make_fpga_policy()``, are not available. | |||
| without arguments - ``make_device_policy()`` and | |||
There was a problem hiding this comment.
Please change the dashes - to parentheses (): "without arguments (make_device_policy() and make_fpga_policy()) are not available."
…hange the dashes - to parentheses (): "without arguments (make_device_policy() and make_fpga_policy()) are not available." Signed-off-by: Sergey Kopienko <sergey.kopienko@intel.com>
danhoeflinger
approved these changes
Aug 6, 2024
|
I have committed the changes to the specification: uxlfoundation/oneAPI-spec#554 |
SergeyKopienko
deleted the
dev/skopienko/declare_dpcpp_default_and_dpcpp_fpga_as_const
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR Declare predefined
dpcpp_defaultanddpcpp fpgapolicies asconst.I hope it's may help to implement move-constructor and move-assignment in the PR #1652 properly.
PR with the changes for oneDPL specification: uxlfoundation/oneAPI-spec#554