Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PROTOTYPE] partition, unique families and ranges API #1708

Merged
merged 15 commits into from
Aug 2, 2024
Merged

[PROTOTYPE] partition, unique families and ranges API #1708

merged 15 commits into from
Aug 2, 2024

Conversation

danhoeflinger
Copy link
Contributor

@danhoeflinger danhoeflinger commented Jul 17, 2024 •
edited
Loading

Adds partition, unique families as well as the ranges API to use two pass scan.

There is some refactoring to the generalized helpers, to simplify sharing between families of scan-like algorithms using this.
Otherwise, this just adds other entry points to use two pass scan.

This also standardizes / adds some zero element short circuits in the ranges API

Note: for the ranges API, I try to hook in to the path to re-use what we have in the main APIs. Specifically, this enables ranges API copy_if to be able to use single workgroup copy_if as well, where it was not previously exposed to that.

Tentative performance results for these families of algorithms are similar to what we have seen with copy_if.

@danhoeflinger danhoeflinger force-pushed the dev/dhoeflin/two_pass_partition_and_unique branch from b737f56 to 6c03803 Compare July 18, 2024 20:43
@danhoeflinger danhoeflinger force-pushed the dev/dhoeflin/two_pass_partition_and_unique branch from 6c03803 to 964a9d2 Compare July 22, 2024 14:05
@adamfidel adamfidel force-pushed the dev/shared/reduce_then_scan_impl branch from 189ff05 to 23f7886 Compare July 24, 2024 18:26
@danhoeflinger danhoeflinger force-pushed the dev/dhoeflin/two_pass_partition_and_unique branch from d55c1d2 to 6c9c8a4 Compare July 24, 2024 22:03
mmichel11
mmichel11 reviewed Jul 29, 2024
View reviewed changes
Copy link
Contributor

@mmichel11 mmichel11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've had a pass over this PR and have a few comments.

include/oneapi/dpl/pstl/hetero/algorithm_impl_hetero.h Outdated Show resolved Hide resolved
include/oneapi/dpl/pstl/hetero/algorithm_ranges_impl_hetero.h Outdated Show resolved Hide resolved
include/oneapi/dpl/pstl/hetero/dpcpp/parallel_backend_sycl.h Outdated Show resolved Hide resolved
include/oneapi/dpl/pstl/hetero/dpcpp/parallel_backend_sycl.h Outdated Show resolved Hide resolved
@danhoeflinger danhoeflinger force-pushed the dev/dhoeflin/two_pass_partition_and_unique branch from 91923bc to a008e90 Compare July 29, 2024 19:59
@mmichel11 mmichel11 force-pushed the dev/shared/reduce_then_scan_impl branch from 5337317 to 0a58980 Compare July 31, 2024 15:19
danhoeflinger and others added 4 commits August 1, 2024 13:02
@danhoeflinger
partition + unique patterns; ranges API
8dcf2e0 
Signed-off-by: Dan Hoeflinger <dan.hoeflinger@intel.com>
@danhoeflinger
[PROTOTYPE] Optimization for unique (#1743)
eeeb3cd 
Unique Optimization and specializing n==1

---------

Signed-off-by: Dan Hoeflinger <dan.hoeflinger@intel.com>
@danhoeflinger
fixes for refactor decide alg at __parallel level
531f2a4 
Signed-off-by: Dan Hoeflinger <dan.hoeflinger@intel.com>

fixes for previous commit (squash)

Signed-off-by: Dan Hoeflinger <dan.hoeflinger@intel.com>
@danhoeflinger
get rid of double dereferences (time this to see if its worth it the …
838d2af 
…changes)

Signed-off-by: Dan Hoeflinger <dan.hoeflinger@intel.com>
@danhoeflinger danhoeflinger force-pushed the dev/dhoeflin/two_pass_partition_and_unique branch from 33a46c1 to 838d2af Compare August 2, 2024 16:57
@danhoeflinger
removing debugging code
c11badb
@danhoeflinger
formatting
d09758b 
Signed-off-by: Dan Hoeflinger <dan.hoeflinger@intel.com>
@danhoeflinger
removing test changes
8928590 
Signed-off-by: Dan Hoeflinger <dan.hoeflinger@intel.com>
@danhoeflinger
consolidate helper for selecting reduce_then_scan
2d63d47 
Signed-off-by: Dan Hoeflinger <dan.hoeflinger@intel.com>
mmichel11
mmichel11 reviewed Aug 2, 2024
View reviewed changes
Copy link
Contributor

@mmichel11 mmichel11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First pass over the recent changes. I marked a few of the places where we touched the code and left ::std. There are a few more but I didn't want to pollute the review comments with them.

include/oneapi/dpl/pstl/hetero/dpcpp/parallel_backend_sycl.h Show resolved Hide resolved
include/oneapi/dpl/pstl/hetero/dpcpp/parallel_backend_sycl_reduce_then_scan.h Show resolved Hide resolved
include/oneapi/dpl/pstl/hetero/dpcpp/parallel_backend_sycl.h Outdated Show resolved Hide resolved
include/oneapi/dpl/pstl/hetero/dpcpp/parallel_backend_sycl.h Outdated Show resolved Hide resolved
include/oneapi/dpl/pstl/hetero/algorithm_impl_hetero.h Outdated Show resolved Hide resolved
include/oneapi/dpl/pstl/hetero/algorithm_impl_hetero.h Outdated Show resolved Hide resolved
include/oneapi/dpl/pstl/hetero/algorithm_ranges_impl_hetero.h Outdated Show resolved Hide resolved
@danhoeflinger
adding assert for empty scans
cb9ff30 
Signed-off-by: Dan Hoeflinger <dan.hoeflinger@intel.com>
@danhoeflinger
::std:: -> std::
129215c 
Signed-off-by: Dan Hoeflinger <dan.hoeflinger@intel.com>
@danhoeflinger
address minor feedback
e510c0d 
Signed-off-by: Dan Hoeflinger <dan.hoeflinger@intel.com>
@danhoeflinger
removing unnecessary comment
b0ada7a 
Signed-off-by: Dan Hoeflinger <dan.hoeflinger@intel.com>
@danhoeflinger
switching copy_if to use common __parallel_reduce_then_scan_copy, and…
13d31a1 
… cleanup

Signed-off-by: Dan Hoeflinger <dan.hoeflinger@intel.com>
@danhoeflinger
reverting formatting only changes
85fb61c 
Signed-off-by: Dan Hoeflinger <dan.hoeflinger@intel.com>
mmichel11
mmichel11 approved these changes Aug 2, 2024
View reviewed changes
Copy link
Contributor

@mmichel11 mmichel11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danhoeflinger
function name change
7f2108c 
Signed-off-by: Dan Hoeflinger <dan.hoeflinger@intel.com>
@danhoeflinger danhoeflinger merged commit 1481aaa into dev/shared/reduce_then_scan_impl Aug 2, 2024
@danhoeflinger danhoeflinger deleted the dev/dhoeflin/two_pass_partition_and_unique branch August 2, 2024 21:03
danhoeflinger added a commit that referenced this pull request Aug 5, 2024
@danhoeflinger
[PROTOTYPE] partition, unique families and ranges API (#1708)
a469687 
Enabling partition and unique family of scan-like algorithms includes ranges API
Making legacy scan user `__result_and_scratch_storage` to match future type for return to compile
Refactoring of `__pattern` / `__parallel` structure for scan-like algorithms for consistency


---------

Signed-off-by: Dan Hoeflinger <dan.hoeflinger@intel.com>
danhoeflinger added a commit that referenced this pull request Aug 6, 2024
@danhoeflinger
[PROTOTYPE] partition, unique families and ranges API (#1708)
1d3b3c9 
Enabling partition and unique family of scan-like algorithms includes ranges API
Making legacy scan user `__result_and_scratch_storage` to match future type for return to compile
Refactoring of `__pattern` / `__parallel` structure for scan-like algorithms for consistency

---------

Signed-off-by: Dan Hoeflinger <dan.hoeflinger@intel.com>
danhoeflinger added a commit that referenced this pull request Aug 6, 2024
@danhoeflinger
[PROTOTYPE] partition, unique families and ranges API (#1708)
24516e7 
Enabling partition and unique family of scan-like algorithms includes ranges API
Making legacy scan user `__result_and_scratch_storage` to match future type for return to compile
Refactoring of `__pattern` / `__parallel` structure for scan-like algorithms for consistency

---------

Signed-off-by: Dan Hoeflinger <dan.hoeflinger@intel.com>
danhoeflinger added a commit that referenced this pull request Aug 7, 2024
@danhoeflinger
[PROTOTYPE] partition, unique families and ranges API (#1708)
0f1e01d 
Enabling partition and unique family of scan-like algorithms includes ranges API
Making legacy scan user `__result_and_scratch_storage` to match future type for return to compile
Refactoring of `__pattern` / `__parallel` structure for scan-like algorithms for consistency

---------

Signed-off-by: Dan Hoeflinger <dan.hoeflinger@intel.com>
danhoeflinger added a commit that referenced this pull request Aug 7, 2024
@danhoeflinger
[PROTOTYPE] partition, unique families and ranges API (#1708)
5d0a96c 
Enabling partition and unique family of scan-like algorithms includes ranges API
Making legacy scan user `__result_and_scratch_storage` to match future type for return to compile
Refactoring of `__pattern` / `__parallel` structure for scan-like algorithms for consistency

---------

Signed-off-by: Dan Hoeflinger <dan.hoeflinger@intel.com>
danhoeflinger added a commit that referenced this pull request Aug 8, 2024
@danhoeflinger
[PROTOTYPE] partition, unique families and ranges API (#1708)
5be9b6f 
Enabling partition and unique family of scan-like algorithms includes ranges API
Making legacy scan user `__result_and_scratch_storage` to match future type for return to compile
Refactoring of `__pattern` / `__parallel` structure for scan-like algorithms for consistency

---------

Signed-off-by: Dan Hoeflinger <dan.hoeflinger@intel.com>
danhoeflinger added a commit that referenced this pull request Aug 8, 2024
@danhoeflinger
[PROTOTYPE] partition, unique families and ranges API (#1708)
3ff4171 
Enabling partition and unique family of scan-like algorithms includes ranges API
Making legacy scan user `__result_and_scratch_storage` to match future type for return to compile
Refactoring of `__pattern` / `__parallel` structure for scan-like algorithms for consistency

---------

Signed-off-by: Dan Hoeflinger <dan.hoeflinger@intel.com>
danhoeflinger added a commit that referenced this pull request Aug 8, 2024
@danhoeflinger
[PROTOTYPE] partition, unique families and ranges API (#1708)
7b4bc30 
Enabling partition and unique family of scan-like algorithms includes ranges API
Making legacy scan user `__result_and_scratch_storage` to match future type for return to compile
Refactoring of `__pattern` / `__parallel` structure for scan-like algorithms for consistency

---------

Signed-off-by: Dan Hoeflinger <dan.hoeflinger@intel.com>
danhoeflinger added a commit that referenced this pull request Aug 14, 2024
@danhoeflinger
[PROTOTYPE] partition, unique families and ranges API (#1708)
6da54e7 
Enabling partition and unique family of scan-like algorithms includes ranges API
Making legacy scan user `__result_and_scratch_storage` to match future type for return to compile
Refactoring of `__pattern` / `__parallel` structure for scan-like algorithms for consistency

---------

Signed-off-by: Dan Hoeflinger <dan.hoeflinger@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamfidel adamfidel adamfidel left review comments

@mmichel11 mmichel11 mmichel11 approved these changes

@timmiesmith timmiesmith Awaiting requested review from timmiesmith

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danhoeflinger @mmichel11 @adamfidel