[pstl-offload] PSTL Offload files cleanup #1752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timmiesmith
reviewed
Aug 26, 2024
timmiesmith
previously approved these changes
Aug 26, 2024
kboyarinov
force-pushed
the
dev/kboyarinov/pstl-offload-cleanup
branch
from
28cb459
to
134c135
Compare
rarutyun
previously approved these changes
Aug 30, 2024
There was a problem hiding this comment.
LGTM!
While I am approving this PR, I strongly prefer that either @danhoeflinger or @dmitriy-sobolev (or both) would review infrastructure modifications
I will try to take a look today. |
There was a problem hiding this comment.
The changes in the CI look good to me.
The changes in the CMake look to me as well after a quick look. There are still many PSTL offload specific things in oneDPL CMake files, but we agreed to leave them to temporarily preserve opportunity to test PSTL offload through oneDPL's test framework.
danhoeflinger
previously approved these changes
Aug 30, 2024
kboyarinov
dismissed stale reviews from danhoeflinger and rarutyun
via
786ccb1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.