Adjust block size for reduce-then-scan based on input type #1782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamfidel
force-pushed
the
dev/adamfidel/transform_reduce_then_scan_block_size
branch
from
7865493
to
deb9be3
Compare
adamfidel
force-pushed
the
dev/adamfidel/transform_reduce_then_scan_block_size
branch
from
deb9be3
to
4dd3068
Compare
Comment on lines
741
to
742
| constexpr std::uint8_t __block_size_factor = sizeof(_ValueType) > sizeof(std::uint32_t) ? sizeof(_ValueType) / sizeof(std::uint32_t) : sizeof(std::uint32_t) / sizeof(_ValueType); | ||
| constexpr std::uint16_t __max_inputs_per_item = sizeof(_ValueType) > sizeof(std::uint32_t) ? 128 / __block_size_factor : 128 * __block_size_factor; |
There was a problem hiding this comment.
Can we adjust this so our baseline is for sizeof(double) types: 64 elements, then scale it by however much smaller the ValueType is?
std::uint8_t __scale = std::min(1, sizeof(double) / sizeof(_ValueType));
std::uing16_t __max_inputs_per_item = 64 * __scale;
We could also limit it to 4x scale if we don't think think 1 byte types will benefit from 512.
There was a problem hiding this comment.
Thanks, this is a cleaner way to write this expression. Although I believe we want to use std::max here instead of std::min.
|
Can we also adjust the |
adamfidel
deleted the
dev/adamfidel/transform_reduce_then_scan_block_size
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Targeting to be included in #1762. This PR adjusts the block size to be bigger or smaller based on the input type.