-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFC] Added numa_support rfc #1535
base: master
Are you sure you want to change the base?
Conversation
Below is the example that demonstrates the use of these APIs to pin threads to different | ||
arenas to each of the NUMA nodes available on a system, submit work across those `task_arena` | ||
objects and into associated `task_group`` objects, and then wait for work again using both | ||
the `task_arena` and `task_group` objects. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the code can be made simpler with std::thread
per NUMA domain, instead of relying only on TBB. On the one hand, it also signals that TBB lacks high-level NUMA APIs. On the other hand, TBB, and task arenas specifically, were designed to work well with application level threads where it makes sense. I think it is much better to assume/suggest each NUMA aware arena to be used by a special application thread than to add extra levels of complication with task groups.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pattern of task_arenas
and task_groups
is what we show in our documentation: for example here. And, probably as a consequence, a pattern we see in applications that use NUMA constraints.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, the documentation shows a suboptimal pattern then. In particular, it does not explicitly set the number of reserved slots to 0, and essentially can lead to undersubscription. Why repeating the same mistake one more time? :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few typos to fix.
@@ -0,0 +1,179 @@ | |||
# Simplified NUMA support in oneTBB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would probably call it "Improved NUMA support".
Correspondingly, the RFC folder could be numa_support_improvements
, meaning that NUMA support is a core feature and improvements are the gist of the proposal.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I understand the whole numa_support_improvements
or simplified_numa_support
directory will be moved to rfcs/supported
directory once these improvements are accepted. There may be another set of NUMA improvements in the future which could result in another numa_support_improvements
directory be created in the same place. And then, when this new set is again accepted, it moves to the same directory. I see potential naming clash issue... It is not related to naming of this directory, but to the naming approach in general. Surely, we could use numa_support_improvements2
as the name of the new directory, but I believe we can do better from the very beginning.
I propose having the directory with the name related to the feature itself, e.g., numa_support
, without additionals such as simplified
or improvement
. This way we will convey the idea that the documents inside directly affect the support of a particular feature. For resolving naming clashes I propose having the file to be named as precise as possible to what the proposal changes avoiding general terms/adjectives such as improved
, increased
, etc.. For example, for sub-RFC that I wrote, I suggest naming the file to something like introduce_tbbbind_static_library
or introduce_tbbbind_statically_linked_with_hwloc
; for NUMA-aware allocators name something like introduce_numa-aware_allocator
; for task_group dependencies name something like introduce_dependencies_for_tasks_in_task_group
; and so on. This way we would avoid name clashing and still this allows grouping similar rfcs together into dedicated folder such as numa_support
. Otherwise, I am afraid that the feature is not elaborated enough to be proposed since it sounds too generic in our mind.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will move to a numa_support directory and change title to "NUMA support"
Co-authored-by: Aleksei Fedotov <aleksei.fedotov@intel.com>
Co-authored-by: Aleksei Fedotov <aleksei.fedotov@intel.com>
Co-authored-by: Aleksei Fedotov <aleksei.fedotov@intel.com>
Co-authored-by: Aleksei Fedotov <aleksei.fedotov@intel.com>
Co-authored-by: Aleksei Fedotov <aleksei.fedotov@intel.com>
Description
Adds RFC for simplified NUMA support
Fixes # - issue number(s) if exists
Type of change
Choose one or multiple, leave empty if none of the other choices apply
Add a respective label(s) to PR if you have permissions
Tests
Documentation
Breaks backward compatibility
Notify the following users
List users with
@
to send notificationsOther information