[0.8.x] Moving to Typescript #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: This might introduce some breaking changes if you are not using Typescript (Only in development mode, regular end-user usage should not be affected)
Codecov ReportBase: 71.64% // Head: 72.00% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #103 +/- ##
============================================
+ Coverage 71.64% 72.00% +0.35%
- Complexity 261 263 +2
============================================
Files 44 44
Lines 871 875 +4
============================================
+ Hits 624 630 +6
+ Misses 247 245 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
# Conflicts: # dist/js/tool.js # resources/js/fields/FormField.vue # resources/js/store/index.js # src/Services/FileManagerService.php
This was referenced Jan 27, 2023
Closed
|
ready to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Target version
0.8.x📣 Summary
This PR introduces a reworked code based which embeds Typescript in every file and component. Vue components have been rewritten to use
<script setup lang="ts">and Pinia store was improved with better static analysis and types.This PR follows the spirit of building a package that should provide a strongly typed codebase to ensure its resilience to user induced issues due to potential poor type checking. Typescript will give the development team a more robust source code to work with. This should also facilitate new feature development and bug fixes.
🚩 Impact and breaking changes
As this PR only modifies the underlying code base to Typescript, no changes should affect the end users of the package. If you are a developer working on the package, please note that no fixes or new features will be accepted if they're not built with Typescript.
We will be thoroughly testing the package before the upcoming release.
And as always, the package is still in its
0.x, and no guarantees are to be made as the core functionality of the package. However, we always aim to avoid BCs, yet sometimes changes are necessary to move forward.