Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENG-8039] Lakeview last modified approach for non blocking processing of commits #108

Merged
merged 13 commits into from
Oct 4, 2024
Merged

[ENG-8039] Lakeview last modified approach for non blocking processing of commits #108

merged 13 commits into from
Oct 4, 2024

Conversation

karankm97
Copy link
Contributor

What is the purpose of the pull request

Lakeview last modified approach for non blocking processing of commits

Brief change log

  • Added BLOCKING and NON_BLOCKING execution modes for active timeline
  • Not blocking execution on incomplete commits
  • Add new test cases

Verify this pull request

  • Change covered by existing unit tests and new test cases
  • Testing to be done using real data

@nimahajan
Copy link

Task linked: ENG-8039 Metadata extractor - using last modified time based approach

@karankm97 karankm97 force-pushed the ENG-8039-lakeview-last-modified-approach branch from ff842e7 to 52bf72b Compare September 27, 2024 05:31
karankm97
karankm97 commented Sep 30, 2024
View reviewed changes
Copy link
Contributor Author

@karankm97 karankm97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/push-image lakeview-nonblock-approach

src/main/java/com/onehouse/metadata_extractor/ActiveTimelineInstantBatcher.java Outdated Show resolved Hide resolved
src/main/java/com/onehouse/metadata_extractor/ActiveTimelineInstantBatcher.java Outdated Show resolved Hide resolved
src/main/java/com/onehouse/metadata_extractor/TimelineCommitInstantsUploader.java Outdated Show resolved Hide resolved
@karankm97 karankm97 force-pushed the ENG-8039-lakeview-last-modified-approach branch from 52bf72b to 45be1cc Compare September 30, 2024 11:55
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 30, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
21 Accepted issues

Measures
0 Security Hotspots
90.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

karankm97
karankm97 commented Sep 30, 2024
View reviewed changes
Copy link
Contributor Author

@karankm97 karankm97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/push-image lakeview-nonblock-approach

@karankm97 karankm97 merged commit c135544 into main Oct 4, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sampan-s-nayak sampan-s-nayak sampan-s-nayak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@karankm97 @nimahajan @sampan-s-nayak