Merge pull request #90 from rushtehrani/fix/namespace

fix: Namespace reserved word validation
onepanelio · Dec 30, 2020 · 611c3bd · 611c3bd
2 parents f1a6a55 + f3922f8
commit 611c3bd
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 2 deletions.
diff --git a/cmd/build_test.go b/cmd/build_test.go
@@ -46,4 +46,4 @@ func Test_generateApplicationNodePoolOptions(t *testing.T) {
 
 	assert.Nil(t, err)
 	assert.Equal(t, nodePoolOptionsExpected, nodePoolOptionsActual)
-}
+}
diff --git a/manifest/manifest.go b/manifest/manifest.go
@@ -125,6 +125,7 @@ func Validate(manifest *util.DynamicYaml) error {
 		"knative-serving":    true,
 		"kube-public":        true,
 		"kube-system":        true,
+		"default":            true,
 	}
 
 	defaultNamespace := manifest.GetValue("application.defaultNamespace")

diff --git a/util/status.go b/util/status.go
@@ -12,7 +12,6 @@ func DeploymentStatus(yamlFile *DynamicYaml) (ready bool, err error) {
 	namespacesToCheck["application-system"] = true
 	namespacesToCheck["onepanel"] = true
 	namespacesToCheck["istio-system"] = true
-	namespacesToCheck["default"] = true
 
 	if yamlFile.HasKey("certManager") {
 		namespacesToCheck["cert-manager"] = true
-Original file line number
+Diff line change
@@ Expand Up / @@ -46,4 +46,4 @@ func Test_generateApplicationNodePoolOptions(t *testing.T) { @@
     	assert.Nil(t, err)
     	assert.Equal(t, nodePoolOptionsExpected, nodePoolOptionsActual)
-    }
+    }