code cleanup + no param mutation

onepanelio · Jan 12, 2021 · 1d0c898 · 1d0c898
1 parent 1355f80
commit 1d0c898
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/pkg/workflow_execution.go b/pkg/workflow_execution.go
@@ -468,8 +468,8 @@ func (c *Client) createWorkflow(namespace string, workflowTemplateID uint64, wor
 			if reErr != nil {
 				return nil, reErr
 			}
-			*param.Value = re.ReplaceAllString(*param.Value, namespace)
-			*param.Value = re.ReplaceAllString(*param.Value, namespace)
+			value := re.ReplaceAllString(*param.Value, namespace)
+			param.Value = &value
 		}
 
 		newParameters = append(newParameters, param)