This repository has been archived by the owner on Apr 28, 2022. It is now read-only.
#259 #260
Merged
#259 #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -593,6 +601,43 @@ private static void checkFortumo(Options options, Context context) { | |||
|
|
|||
| } | |||
|
|
|||
| private static void checkNokia(Options options, Context context) { | |||
There was a problem hiding this comment.
Why does method static? OpenIab helper contains Options in field. You can make method non-static and remove Option from parametres.
There was a problem hiding this comment.
Same for Context parameter.
There was a problem hiding this comment.
All these methods should be moved later to an Utils class.
Conflicts: library/src/org/onepf/oms/OpenIabHelper.java
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.