[WIP] Configure custom domains #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
tarteo
commented
Mar 1, 2024
•
tarteo
commented
Use the yaml in argocd.application.config to get the urls of the application
argocd_sale: Add tests
ByteMeAsap
reviewed
Mar 6, 2024
|
|
||
| _onKeyDown: function () { | ||
| this.$input.removeClass("is-invalid"); | ||
| this.$input.removeClass("is-valid"); |
There was a problem hiding this comment.
you can include both the classes at once separated by space removeClass("is-invalid is-valid")
|
|
||
| if (!domain) { | ||
| self.$input.removeClass("is-invalid"); | ||
| self.$input.removeClass("is-valid"); |
There was a problem hiding this comment.
you can include both the classes at once separated by space removeClass("is-invalid is-valid")
|
I want to add A record support |
Added the application_set model to support multiple application sets. Also cleaned up tha application code a bit.
# Conflicts: # argocd_sale/demo/product_template_demo.xml # argocd_sale/models/account_move.py # argocd_sale/tests/__init__.py # argocd_website/README.rst
…goCD and fixed commit message.
- Renamed is_master_deployment to is_master - added domain YAML overrides to application tags to be more flexible with changes in YAML layout in different application sets - application now has an is_deployed field that's True when both it and its application set are deployed - application now has an is_application_set_deployed field to indicate whether its application set is deployed - added nice colors to the lists of applications and application sets to indicate they are deployed - Added various jumbotron warnings to applications and application sets - Added a setting to disable direct deployment - Added a delay to application set destruction when calling through the job queue - It's now only possible to destroy application sets with deployed applications through the job queue
…s and application sets.
MrGigSolutions
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.