Progressive JPEG #1181
Merged
Progressive JPEG #1181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lixiang1994 Thanks for these commits. I didn't get a time for it now, but feel free to let me know if you get to a milestone so I can start to have a look at it as soon as possible! |
|
@onevcat 👌 I think it is ok. |
|
@lixiang1994 It is fantastic at a brief look and just works like magic! I will create a PR to your master branch later with some obvious changes, then let's check some details before we can merge and release it. |
Conceptual proving of side effect option
…Effect 只保留public相关的方法, 其他细节优化等
|
LGTM so far. Thanks for these commits. I guess we can release progressive support as a beta for now, during the while, we still need to improve the quality, add necessary tests and write documentation for it. But it is another story, this PR is large enough and good to be merged. |
|
😘 |
skoduricg
pushed a commit
to rentpath/Kingfisher
that referenced
this pull request
Sep 24, 2021
Progressive JPEG
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.