Optimize MD5 String By reduce Function
#1183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! I am not sure which is faster, but I guess there should not be too much difference. Any chance to create some benchmark? So we can decide whether we should adopt to |
|
Tried to have a benchmark and it shows about 15% faster! |
skoduricg
pushed a commit
to rentpath/Kingfisher
that referenced
this pull request
Sep 24, 2021
…educe Optimize MD5 String By `reduce` Function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a question，in "String+MD5.swift"，use “reduce” func may be better than use “map” and “joined” to create MD5 string by an [UInt8]，"map" may be cause space complexity O(n) ，it create a temp array [String]，Or are there other benefits to using "map" and "joined"?