修复各种扩展中taskIdentifier的线程安全问题 它在不同线程中调用可能出现崩溃问题

[lixiang1994]

可用类似代码模拟场景复现, 该问题是通过Bugly收集到的

[onevcat]

These extension methods belong to the UI part, and they are not designed as thread-safe methods.

Similar to the UIKit things, you need to make sure to call them from the main thread to keep all accessing safe.

[lixiang1994]

onShouldApply闭包中使用了taskIdentifier, onShouldApply可能在任何线程被调用

[lixiang1994]

或者需要确保onShouldApply只在主线程内调用, 你更倾向于哪一种?

[lixiang1994]

@onevcat ??? 怎么说

[onevcat]

It makes sense. But several concerns:

1. Why you didn't add lock in the setter of ImageView and NSButton extensions. Should we also need lock it in the identifier setter?
2. Can you remove the DevelopmentTeam changing from the PR?

[lixiang1994]

objc_getAssociatedObject和objc_setAssociatedObject是线程安全的.
AssociationsManager 通过持有一个自旋锁spinlock_t保证对AssociationsHashMap的操作是线程安全的, 即每次只会有一个线程对AssociationsHashMap进行操作.
我们的问题是Box中的value并不是线程安全的, 所以只需要在value相关操作时增加锁就可以了.

[lixiang1994]

🐱喵喵喵~