Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable background decoding for images from the in memory cache. #257

Merged
merged 1 commit into from Feb 29, 2016
Merged

Disable background decoding for images from the in memory cache. #257

merged 1 commit into from Feb 29, 2016

Conversation

ghost
Copy link

@ghost ghost commented Feb 29, 2016

  • this improves the performance of image loading for in-memory cached
    images.

We observe a flicker when returing to an image view that renders
multiple images using kf_setImageWithResource. We traced through the
calls and found a place where Kingfisher attempts to re-decode an image
that has already been decoded and stored in the in memory cache.

We think that it is safe to pull out an image from the in memory cache and not
attempt to decode again.

- this improves the performance of image loading for in-memory cached
  images.

We observe a flicker when returing to an image view that renders
multiple images using `kf_setImageWithResource`.  We traced through the
calls and found a place where Kingfisher attempts to re-decode an image
that has already been decoded and stored in the in memory cache.

We think that it is safe to pull out an image from the in memory cache and not
attempt to decode again.
@codecov-io
Copy link

Current coverage is 77.28%

Merging #257 into master will increase coverage by +0.38% as of 718e050

@@            master    #257   diff @@
======================================
  Files           11      11       
  Stmts         1260    1250    -10
  Branches         0       0       
  Methods          0       0       
======================================
- Hit            969     966     -3
  Partial          0       0       
+ Missed         291     284     -7

Review entire Coverage Diff as of 718e050

Powered by Codecov. Updated on successful CI builds.

@onevcat
Copy link
Owner

onevcat commented Feb 29, 2016

Yes, you are right.

onevcat added a commit that referenced this pull request Feb 29, 2016
Disable background decoding for images from the in memory cache.
@onevcat onevcat merged commit 4cf3212 into onevcat:master Feb 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants