Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude NSButton extension #292

Merged
merged 4 commits into from
Apr 22, 2016
Merged

Exclude NSButton extension #292

merged 4 commits into from
Apr 22, 2016

Conversation

onevcat
Copy link
Owner

@onevcat onevcat commented Apr 22, 2016

No description provided.

@onevcat onevcat mentioned this pull request Apr 22, 2016
Merged
@jzau
Copy link
Contributor

jzau commented Apr 22, 2016

I think you can remove some codes of os version check in UIButton extension file as well.

@onevcat
Copy link
Owner Author

onevcat commented Apr 22, 2016

It makes sense! Thanks for pointing it out.

@codecov-io
Copy link

Current coverage is 82.29%

Merging #292 into master will decrease coverage by -0.14% as of d190108

@@            master    #292   diff @@
======================================
  Files           13      13       
  Stmts         1412    1412       
  Branches         0       0       
  Methods          0       0       
======================================
- Hit           1164    1162     -2
  Partial          0       0       
- Missed         248     250     +2

Review entire Coverage Diff as of d190108

Powered by Codecov. Updated on successful CI builds.

@onevcat onevcat merged commit cd181c6 into master Apr 22, 2016
@onevcat onevcat deleted the jackyzh-master branch April 22, 2016 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@onevcat @jzau @codecov-io