Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jdmoreira master #430

Merged
merged 6 commits into from
Sep 12, 2016
Merged

Jdmoreira master #430

merged 6 commits into from
Sep 12, 2016

Conversation

onevcat
Copy link
Owner

@onevcat onevcat commented Sep 12, 2016

No description provided.

@codecov-io
Copy link

Current coverage is 72.55% (diff: 68.39%)

Merging #430 into master will decrease coverage by 1.72%

@@             master       #430   diff @@
==========================================
  Files            14         16     +2   
  Lines          1691       1767    +76   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits           1256       1282    +26   
- Misses          435        485    +50   
  Partials          0          0          

Powered by Codecov. Last update b1fa34e...841c6b6

@onevcat onevcat merged commit bdf4c90 into master Sep 12, 2016
@onevcat onevcat deleted the jdmoreira-master branch September 12, 2016 07:25
@jdmoreira
Copy link
Contributor

I've seen you merged and did a few changes. I'm sorry I didn't had much time the last couple of days. Thanks for taking the time.

I agree that the keeping the objc_set/getObject and using Box is a much better solution 👍

@onevcat
Copy link
Owner Author

onevcat commented Sep 13, 2016

@jdmoreira Hi, I think your wrapper solution is also great. But the blocking is that it cannot compile in Release mode with -O optimization. It crashes LLVM in the conversion of T to AnyObject. Furthermore, in Swift 3 we cannot depend on AnyObject to check class (since everything is imported as Any now). So I guess it would be better to leave it to us developers to decide which should be in box.

I am working on Swift 3 for the indicator now. Glad and honor that you help to improve it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants