Add option to supply default path extension #456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Especially useful when using Kingfisher on macOS and wanting to add drag-drop. Most web input fields won't accept files without a path extension (like .jpg). Currently only supports a single default path extension. Could later be expanded to include a path extension per image.
Current coverage is 74.40% (diff: 100%)@@ master #456 diff @@
==========================================
Files 21 21
Lines 2194 2196 +2
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 1627 1634 +7
+ Misses 567 562 -5
Partials 0 0
|
onevcat
approved these changes
Sep 27, 2016
|
LGTM |
rain2540
pushed a commit
to rain2540/Kingfisher
that referenced
this pull request
Feb 28, 2017
Add option to supply default path extension
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Especially useful when using Kingfisher on macOS and wanting to add
drag-drop. Most web input fields won't accept files without a path
extension (like .jpg).
Currently only supports a single default path extension. Could later
be expanded to include a path extension per image.