Also set the webURL to nil when resource is nil #598
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
while using Kingfisher in a collection view I noticed that in some cases the image views weren't updated as expected.
This is what I'm doing:
image-url
using KFnil
with a placeholderWhat I expect at this point is for the image view to display the placeholder, what happens is that it still displays the image at
image-url
.I looked a bit into the
setImage
method inImageView+Kingfisher
and noticed that the cause of this issue might be the fact thatwebURL
is not updated when setImage is called with anil
resource thus letting the completion block of the download task update the image even if the operation was cancelled and thesetImage
called again.Also, the same this is probably happening for
UIButton
andNSButton
extensions but I wanted to open this PR before editing any other method.