Swift 4 Support #704
Merged
Swift 4 Support #704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@onevcat when are you merging this? Would love to continue using Kingfisher in my project! |
|
@lfarah It will not be merged until Swift 4 officially released. Before that, you could just use the "swift4" branch to continue use Kingfisher is your Swift 4 project. |
|
Hey. There is an issues withe carthage and the new build system. Would it be ok to revert to the old build system?? |
|
@lightsprint09 |
Disable gather coverage data in scheme test action
# Conflicts: # Kingfisher.xcodeproj/xcshareddata/xcschemes/Kingfisher-macOS.xcscheme # Kingfisher.xcodeproj/xcshareddata/xcschemes/Kingfisher-tvOS.xcscheme # Kingfisher.xcodeproj/xcshareddata/xcschemes/Kingfisher.xcscheme # Sources/ImageView+Kingfisher.swift
petarlazarov
pushed a commit
to dowjones-mobile/Kingfisher
that referenced
this pull request
Oct 6, 2021
Swift 4 Support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.