Support caching original images on a different cache #794
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey hey 👋,
Here at Zeplin, we needed a way to cache the original images on a different cache (rather than the target cache) when using a custom image processor. For example, we are fetching images with a custom thumbnail image processor, and we want to store these thumbnails on a 'thumbnail' cache, and store the originals on a 'snapshots' cache.
To accomplish this, we wrote a
originalCache
toKingfisherOptionsInfoItem
on our fork.originalCache
is basically used for storing and retrieving original images if paired with a non-default image processor. It defaults totargetCache
to make it an optional item.I've also included a typo fix and an optimization to prevent double caching if
cacheOriginalImage
is selected when used with the default image processor.Thought this may be a good addition to the main repo. I wasn't able to write or run any tests because of the missing
Kingfisher-TestImages
folder.