new image processors: blend, compositing #818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also, I changed macOS version to 10.11 to successfully build and run. |
|
@yemodin Looks great. However, if we increase the minimal deploy target, we have to release another major update since it breaks compatibility. May I know which API you are using is 10.11 above? And do not worry about the failing tests. If we could add this processor to the framework, I will check and fix these tests. |
|
@onevcat I changed only demo project target, not framework target. Next lines of macOS demo require 10.11+: |
|
Also, I added the test to each image processor. And made the pull request for image assets: |
|
Oh, cool! I will check it now. |
petarlazarov
pushed a commit
to dowjones-mobile/Kingfisher
that referenced
this pull request
Oct 6, 2021
new image processors: blend, compositing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds blending/compositing(macOS) processors. Allows easily blend/compositing.
For example, I was needed to blend unedited images which have the different background color so they will appear blended with the background color of my interface.