Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix possible invalid redeclaration error #819

Merged
merged 1 commit into from
Dec 4, 2017

Conversation

XmasRights
Copy link
Contributor

  • Array extension in AnimatedImageView.swift uses default access level for subscript(safe:) method
  • This is a common Array extension method to make, and using this current access control level can lead to Invalid Redeclaration of function errors in Xcode

Steps to reproduce:

  1. Create a new, empty Swift project, and import the Kingfisher library
  2. Add the same Array extension in AppDelegate.swift
  • Note: this error will occur regardless of the access control level of any duplicate extension (so even a fileprivate subscript(safe:) elsewhere will trigger the error)

@onevcat
Copy link
Owner

onevcat commented Dec 4, 2017

Great catch!

@onevcat onevcat merged commit a4ae1e7 into onevcat:master Dec 4, 2017
petarlazarov pushed a commit to dowjones-mobile/Kingfisher that referenced this pull request Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants