Add new method to ImageDownloaderDelegate - didFinishDownloadingImageForURL:with:error #901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ishDownloadingImageForURL:with:)` that gets called when the `ImageDownloader` object completes a downloading request with success or failure.
…g.: server responds with 404)
|
@tomaskraina Thanks for it! Happened to be quite busy recently but this addition looks fine to me at the first glance. I'd take a detail look at it later and get you back then! |
|
Thanks! |
nanoxd
reviewed
May 15, 2018
| @@ -95,3 +95,15 @@ extension ViewController: UICollectionViewDataSourcePrefetching { | |||
| ImagePrefetcher(urls: urls).start() | |||
| } | |||
| } | |||
|
|
|||
|
|
|||
| // Inspired by: https://fdp.io/blog/2018/03/22/supporting-compactmap-in-swift-4/ | |||
There was a problem hiding this comment.
👋 It's funny to see my blog post on a library I use 😄
petarlazarov
pushed a commit
to dowjones-mobile/Kingfisher
that referenced
this pull request
Oct 6, 2021
…-finish Add new method to ImageDownloaderDelegate - didFinishDownloadingImageForURL:with:error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows using network activity indicator correctly. Fixes #605
I have been using this my fork for some time and thought it would be good idea to merge it back to the official repo.
Maybe the naming could be better. Any ideas?