Conform WKInterfaceImage to KingfisherCompatible #913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rdgborges Seems cool at first glance! Thanks for it. I'd check it later and merge it at a proper time. :) |
|
Very cool. Was just looking into this for RxKingfisher and gave up on watchOS for it :) |
petarlazarov
pushed a commit
to dowjones-mobile/Kingfisher
that referenced
this pull request
Oct 6, 2021
…eextensions Conform WKInterfaceImage to KingfisherCompatible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds KingfisherCompatible protocol conformance to WKInterfaceImage.
When starting to use Kingfisher with WatchKit is natural for developers to search for
kf.setImage(resource:)in WKInterfaceImage. With this PR, I intend to facilitate the use of Kingfisher by watchOS developers. 🙂The ideia is to begin with a simple extension adding
setImage(resource:)then adding more features like placeholder and completionHandler in the next PRs.Feedbacks are always welcome!