Changed ImagePrefetcher to process images in a background queue instead of the main queue #957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ad of the main queue
|
I believe our app is suffering from the same issue. We prefetch a LOT of images when we first load the app, and our tableView starts to stutter. @onevcat I think this would be a great addition to the library 👍 |
|
Sorry for the late reply. LGTM at the first glance. I'd take a detailed look at these changes and merge it ASAP. Thanks! |
|
Great, thank you @onevcat! |
petarlazarov
pushed a commit
to dowjones-mobile/Kingfisher
that referenced
this pull request
Oct 6, 2021
Changed ImagePrefetcher to process images in a background queue instead of the main queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we tried to use ImagePrefetcher in a collection view that loaded the next few dozen images it caused very noticeable stuttering while scrolling. By moving the logic that handles the image downloading to its own DispatchQueue, it removed the stuttering completely and runs much smoother.
I can't see any side effects from this change so I figured I'd put in a pull request in case anyone else wanted to make their app a bit smoother. If you are curious they amount of stuttering it fixed, I'm attaching videos of how it looks before and after the proposed change.
Kingfisher-before-and-after.zip